Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6232)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2701343002: Implement permission embargo suppression metrics. (Closed)
Patch Set: Clean up Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index f1efe4cfa5cf9116900c0fe929200567fbda7951..5b2a08c34b6d08375221cb15f5823e5bc2cdf272 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -48,6 +48,16 @@ enum SafeBrowsingResponse {
RESPONSE_NUM,
};
+// Any new values should be inserted immediately prior to STATUS_NUM.
+enum PermissionEmbargoStatus {
+ NOT_EMBARGOED = 0,
+ PERMISSIONS_BLACKLISTING = 1,
+ REPEATED_DISMISSALS = 2,
+
+ // Keep this at the end.
+ STATUS_NUM,
+};
+
// A bundle for the information sent in a PermissionReport.
struct PermissionReportInfo {
PermissionReportInfo(
@@ -72,15 +82,6 @@ struct PermissionReportInfo {
int num_prior_ignores;
};
-enum PermissionEmbargoStatus {
- NOT_EMBARGOED = 0,
- PERMISSIONS_BLACKLISTING = 1,
- REPEATED_DISMISSALS = 2,
-
- // Keep this at the end.
- STATUS_NUM,
-};
-
// Provides a convenient way of logging UMA for permission related operations.
class PermissionUmaUtil {
public:
@@ -137,9 +138,11 @@ class PermissionUmaUtil {
const GURL& revoked_origin,
Profile* profile);
- static void RecordPermissionEmbargoStatus(
+ static void RecordEmbargoPromptSuppression(
PermissionEmbargoStatus embargo_status);
+ static void RecordEmbargoStatus(PermissionEmbargoStatus embargo_status);
+
static void RecordSafeBrowsingResponse(base::TimeDelta response_time,
SafeBrowsingResponse response);

Powered by Google App Engine
This is Rietveld 408576698