Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2701333002: Add integration tests for WebAPKs (Closed)
Patch Set: Merge branch 'remove_load_url' into integration_test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 360b52624cac92b4f4021ac8f1d2fbdeca45270c..5d78b491c962ebcaa752d04fbbdb49554221b2f7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -169,8 +169,10 @@ public class WebApkActivity extends WebappActivity {
public void onDeferredStartup() {
super.onDeferredStartup();
- mUpdateManager = new WebApkUpdateManager(this);
- mUpdateManager.updateIfNeeded(getActivityTab(), (WebApkInfo) mWebappInfo);
+ mUpdateManager = createUpdateManager();
+ if (mUpdateManager != null) {
+ mUpdateManager.updateIfNeeded(getActivityTab(), (WebApkInfo) mWebappInfo);
+ }
}
@Override
@@ -204,4 +206,9 @@ public class WebApkActivity extends WebappActivity {
}
super.onDestroyInternal();
}
+
+ /* Creates WebApkUpdateManager. In its own function for the sake of tests. */
+ protected WebApkUpdateManager createUpdateManager() {
+ return new WebApkUpdateManager(this);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698