Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 270133003: Poison .arguments and .caller for generator functions (Closed)

Created:
6 years, 7 months ago by wingo
Modified:
6 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Poison .arguments and .caller for generator functions R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21362

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address nits, add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -29 lines) Patch
M src/bootstrapper.cc View 1 6 chunks +77 lines, -26 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +8 lines, -1 line 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/harmony/generators-poisoned-properties.js View 1 1 chunk +42 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/generators-runtime.js View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
6 years, 7 months ago (2014-05-06 14:11:37 UTC) #1
rossberg
https://codereview.chromium.org/270133003/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/270133003/diff/1/src/bootstrapper.cc#newcode307 src/bootstrapper.cc:307: Handle<JSFunction> throw_type_error_function; Nit: can we somehow rename this to ...
6 years, 7 months ago (2014-05-07 09:19:54 UTC) #2
wingo
New patchset addresses nits and adds tests. Thanks for the review.
6 years, 7 months ago (2014-05-07 10:17:31 UTC) #3
rossberg
lgtm
6 years, 7 months ago (2014-05-07 10:59:06 UTC) #4
wingo
6 years, 7 months ago (2014-05-19 10:47:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698