Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2701313006: Fix ast_to_text output to pass tests. (Closed)

Created:
3 years, 10 months ago by jensj
Modified:
3 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ast_to_text output to pass tests. Previous commit (86d788e6994bf9e7b8f93d2132cd1099d60229ec) broke kernel tests. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/48d057bdc3645d0ea4b5569b638c87b68273b1fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/kernel/lib/text/ast_to_text.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 10 months ago (2017-02-22 11:50:24 UTC) #2
asgerf
lgtm
3 years, 10 months ago (2017-02-22 11:50:59 UTC) #3
jensj
3 years, 10 months ago (2017-02-22 11:51:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48d057bdc3645d0ea4b5569b638c87b68273b1fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698