Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc

Issue 2701313002: Adds a modal dialog implementation of the settings reset prompt. (Closed)
Patch Set: Fix constness in mock test class Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc
diff --git a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc
index 5f992dde01d847e2191033792b139b7640ed97c0..f8a302dbf4e25f91b0b66c291828ae2971184a26 100644
--- a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc
+++ b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc
@@ -25,20 +25,16 @@ namespace {
constexpr char kSettingsResetPromptFeatureName[] = "SettingsResetPrompt";
+bool IsPromptEnabled() {
+ return base::FeatureList::IsEnabled(kSettingsResetPrompt);
+}
+
} // namespace.
const base::Feature kSettingsResetPrompt{kSettingsResetPromptFeatureName,
base::FEATURE_DISABLED_BY_DEFAULT};
// static
-bool SettingsResetPromptConfig::IsPromptEnabled() {
- // TODO(alito): Add prefs to local state to track when the user was
- // last prompted and ensure that we only prompt once per reset prompt
- // wave.
- return base::FeatureList::IsEnabled(kSettingsResetPrompt);
-}
-
-// static
std::unique_ptr<SettingsResetPromptConfig> SettingsResetPromptConfig::Create() {
if (!IsPromptEnabled())
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698