Adds a modal dialog implementation of the settings reset prompt.

chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SETTINGS_RESET_PROMPT_SETTINGS_RESET_PROMPT_CONFIG_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SETTINGS_RESET_PROMPT_SETTINGS_RESET_PROMPT_CONFIG_H_
 
 #include <cstddef>
 #include <memory>
 #include <string>
 #include <unordered_map>
 #include <vector>
 
 #include "base/feature_list.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 
 class GURL;
 
 namespace safe_browsing {
 
-// Exposed for testing.
 extern const base::Feature kSettingsResetPrompt;
 
 // Encapsulates the state of the reset prompt experiment as well as
 // associated data.
 class SettingsResetPromptConfig {
  public:
-  // Returns true if the settings reset prompt study is enabled.
-  static bool IsPromptEnabled();
   // Factory method for creating instances of SettingsResetPromptConfig.
   // Returns nullptr if |IsPromptEnabled()| is false or if something is wrong
   // with the config parameters.
   static std::unique_ptr<SettingsResetPromptConfig> Create();
 
   virtual ~SettingsResetPromptConfig();

[sky, 2017/02/21 17:37:27]

If you're going to cleanup this file, move the destructor above other functions
(see style guide).

[alito, 2017/02/23 02:31:59]

According to Google's external C++ style guide, factory functions should come
before the destructor: "prefer the following order: types (including typedef,
using, and nested structs and classes), constants, factory functions,
constructors, assignment operators, destructor, all other methods, data
members". Unless Chromium adds something to this (couldn't find anything...).

[sky, 2017/02/23 04:27:31]

I clearly missed the 'factory functions' sections. Now I wonder if that changed
at some point...

 
   // Returns a non-negative integer ID if |url| should trigger a
   // settings reset prompt and a negative integer otherwise. The IDs
   // identify the domains or entities that we want to prompt the user
   // for and can be used for metrics reporting.
   virtual int UrlToResetDomainId(const GURL& url) const;
 
   // The delay before showing the reset prompt after Chrome startup.
   base::TimeDelta delay_before_prompt() const;
   // Whether the prompt dialog should be modal.
@@ skipping 21 matching lines @@
   // Other feature parameters.
   base::TimeDelta delay_before_prompt_;
   bool use_modal_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsResetPromptConfig);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SETTINGS_RESET_PROMPT_SETTINGS_RESET_PROMPT_CONFIG_H_