Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: chrome/browser/media/encrypted_media_browsertest.cc

Issue 2701203003: media: Prefer decrypting pipeline when CDM is attached (Closed)
Patch Set: comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/media/encrypted_media_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, InvalidResponseKeyError) { 552 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, InvalidResponseKeyError) {
553 RunInvalidResponseTest(); 553 RunInvalidResponseTest();
554 } 554 }
555 555
556 // Strictly speaking this is not an "encrypted" media test. Keep it here for 556 // Strictly speaking this is not an "encrypted" media test. Keep it here for
557 // completeness. 557 // completeness.
558 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, ConfigChangeVideo_ClearToClear) { 558 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, ConfigChangeVideo_ClearToClear) {
559 TestConfigChange(ConfigChangeType::CLEAR_TO_CLEAR); 559 TestConfigChange(ConfigChangeType::CLEAR_TO_CLEAR);
560 } 560 }
561 561
562 // TODO(xhwang): Support switching from clear to encrypted and fix the test 562 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, ConfigChangeVideo_ClearToEncrypted) {
563 // expectation. Currently this test passes when we do decrypt-and-decode but
564 // fails when we do decrypt-only due to how decoder reselection during config
565 // change is handled. See http://crbug.com/597443
566 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest,
567 DISABLED_ConfigChangeVideo_ClearToEncrypted) {
568 TestConfigChange(ConfigChangeType::CLEAR_TO_ENCRYPTED); 563 TestConfigChange(ConfigChangeType::CLEAR_TO_ENCRYPTED);
569 } 564 }
570 565
571 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, ConfigChangeVideo_EncryptedToClear) { 566 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, ConfigChangeVideo_EncryptedToClear) {
572 TestConfigChange(ConfigChangeType::ENCRYPTED_TO_CLEAR); 567 TestConfigChange(ConfigChangeType::ENCRYPTED_TO_CLEAR);
573 } 568 }
574 569
575 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, 570 IN_PROC_BROWSER_TEST_P(EncryptedMediaTest,
576 ConfigChangeVideo_EncryptedToEncrypted) { 571 ConfigChangeVideo_EncryptedToEncrypted) {
577 TestConfigChange(ConfigChangeType::ENCRYPTED_TO_ENCRYPTED); 572 TestConfigChange(ConfigChangeType::ENCRYPTED_TO_ENCRYPTED);
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 } 735 }
741 736
742 IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, VerifyCdmHostTest) { 737 IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, VerifyCdmHostTest) {
743 TestNonPlaybackCases(kExternalClearKeyVerifyCdmHostTestKeySystem, 738 TestNonPlaybackCases(kExternalClearKeyVerifyCdmHostTestKeySystem,
744 kUnitTestSuccess); 739 kUnitTestSuccess);
745 } 740 }
746 741
747 #endif // BUILDFLAG(ENABLE_PEPPER_CDMS) 742 #endif // BUILDFLAG(ENABLE_PEPPER_CDMS)
748 743
749 } // namespace chrome 744 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | content/browser/media/encrypted_media_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698