Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 2701163002: Avoid pathological layout on nested percent height tables (Closed)
Patch Set: bug 687061 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTable.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.h b/third_party/WebKit/Source/core/layout/LayoutTable.h
index b2f86d67bce30d239fc79d6270d72e24bc1f7185..26b77558db50ed09970cd49a1489a757a82ed215 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.h
@@ -42,6 +42,7 @@ class LayoutTableSection;
class TableLayoutAlgorithm;
enum SkipEmptySectionsValue { DoNotSkipEmptySections, SkipEmptySections };
+enum TableHeightChangingValue { TableHeightNotChanging, TableHeightChanging };
// LayoutTable is the LayoutObject associated with
// display: table or inline-table.
@@ -515,7 +516,8 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
void layoutCaption(LayoutTableCaption&, SubtreeLayoutScope&);
void layoutSection(LayoutTableSection&,
SubtreeLayoutScope&,
- LayoutUnit logicalLeft);
+ LayoutUnit logicalLeft,
+ TableHeightChangingValue);
// Return the logical height based on the height, min-height and max-height
// properties from CSS. Will return 0 if auto.
@@ -599,6 +601,7 @@ class CORE_EXPORT LayoutTable final : public LayoutBlock {
LayoutUnit m_blockOffsetToFirstRepeatableHeader;
LayoutUnit m_rowOffsetFromRepeatingHeader;
+ LayoutUnit m_oldAvailableLogicalHeight;
};
inline LayoutTableSection* LayoutTable::topSection() const {

Powered by Google App Engine
This is Rietveld 408576698