third_party/WebKit/LayoutTests/fast/table/layout-section-when-table-height-changes.html - Issue 2701163002: Avoid pathological layout on nested percent height tables

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/layout-section-when-table-height-changes.html

Issue 2701163002: Avoid pathological layout on nested percent height tables (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-intrinsic-dimensions/height-css-tables-expected.html ('k') | third_party/WebKit/LayoutTests/fast/table/layout-section-when-table-height-changes-2.html » ('j') | third_party/WebKit/LayoutTests/fast/table/layout-section-when-table-height-changes-2.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 table {

	4 table-layout: fixed;

	5 height: 100%;

	6 width: 100%;

	7 }

	8 </style>

	9 <p> crbug.com/691968: There should be no scrollbar. </p>

	10 <div id="container" style="width: 400px; height: 400px; overflow: auto; overflow -x: hidden;">

	11 <table id="table" data-expected-height=200>

	12 <colgroup>

	13 <col style="width: 1161px;">
	mstensho (USE GERRIT) 2017/02/20 13:01:31 Is the insane width necessary? Are the COLGROUP an Is the insane width necessary? Are the COLGROUP and COL elements necessary at all? rhogan 2017/02/20 18:38:16 Yes, otherwise m_columnLogicalWidthChanged gets se Show quoted text On 2017/02/20 at 13:01:31, mstensho wrote: > Is the insane width necessary? Are the COLGROUP and COL elements necessary at all? Yes, otherwise m_columnLogicalWidthChanged gets set and the test lays out correctly regardless. mstensho (USE GERRIT) 2017/02/20 19:02:32 OK, thanks for explaining. I think I used border-s Show quoted text On 2017/02/20 18:38:16, rhogan wrote: > On 2017/02/20 at 13:01:31, mstensho wrote: > > Is the insane width necessary? Are the COLGROUP and COL elements necessary at > all? > > Yes, otherwise m_columnLogicalWidthChanged gets set and the test lays out > correctly regardless. OK, thanks for explaining. I think I used border-spacing:0 to work around the m_columnLogicalWidthChanged false positives, for the record.
	14 </colgroup>

	15 <tbody>

	16 <tr>

	17 <td></td>

	18 </tr>

	19 </tbody>

	20 </table>

	21 </div>

	22 <div id="results"></div>

	23 <script src="../../resources/check-layout.js"></script>
	mstensho (USE GERRIT) 2017/02/20 13:01:31 Time to switch to check-layout-th.js , to avoid th Time to switch to check-layout-th.js , to avoid the -expected* files. See LayoutTests/fast/multicol/balance-line-underflow-1.html for an example. Note that you also need to (at least to my knowledge) include testharnessreport.js and testharness.js, just like that test does.
	24 <script>

	25 document.body.offsetTop;

	26 document.getElementById("container").style.height = "200px";

	27 checkLayout('#table', results);

	28 </script>

OLD	NEW