chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc - Issue 2701123002: AppList Performance Optimization 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc

Issue 2701123002: AppList Performance Optimization 2 (Closed)

Patch Set: Cache the tokenized name Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/search_controller_factory.cc ('k') | chrome/browser/ui/app_list/search/webstore/webstore_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc

diff --git a/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc b/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc

index 1adf31c8439b833885bc37436fa994f2d51f00eb..bea13e27bb236b3f35441509351238b635136c20 100644

--- a/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc

+++ b/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc

@@ -76,9 +76,10 @@ class SuggestionsSearchProviderTest : public AppListTestBase {

suggestions_search_->Start(false, base::UTF8ToUTF16(query));

// Sort results from most to least relevant.

- std::vector<SearchResult*> sorted_results(

- suggestions_search_->results().begin(),

- suggestions_search_->results().end());

+ std::vector<SearchResult*> sorted_results;

+ sorted_results.reserve(suggestions_search_->results().size());

+ for (const auto& result : suggestions_search_->results())

+ sorted_results.emplace_back(result.get());

std::sort(sorted_results.begin(), sorted_results.end(), &MostRelevant);

std::string result_str;