AppList Performance Optimization 2

chrome/browser/ui/app_list/search/omnibox_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/search/omnibox_provider.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 29 matching lines @@
       metrics::OmniboxEventProto::INVALID_SPEC, false, false, true, true, false,
       ChromeAutocompleteSchemeClassifier(profile_)));
 }
 
 void OmniboxProvider::Stop() {
   controller_->Stop(false);
   is_voice_query_ = false;
 }
 
 void OmniboxProvider::PopulateFromACResult(const AutocompleteResult& result) {
-  ClearResults();
-  for (ACMatches::const_iterator it = result.begin();
-       it != result.end();
-       ++it) {
-    if (!it->destination_url.is_valid())
+  SearchProvider::Results new_results;
+  new_results.reserve(result.size());
+  for (const AutocompleteMatch& match : result) {
+    if (!match.destination_url.is_valid())
       continue;
 
-    Add(std::unique_ptr<SearchResult>(new OmniboxResult(
-        profile_, list_controller_, controller_.get(), is_voice_query_, *it)));
+    new_results.emplace_back(base::MakeUnique<OmniboxResult>(
+        profile_, list_controller_, controller_.get(), is_voice_query_, match));
   }
+  SwapResults(&new_results);
 }
 
 void OmniboxProvider::OnResultChanged(bool default_match_changed) {
-  const AutocompleteResult& result = controller_->result();
-  PopulateFromACResult(result);
+  PopulateFromACResult(controller_->result());
 }
 
 }  // namespace app_list