Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 27011005: Disable optimization in prdtoa.c under VS2013. (Closed)

Created:
7 years, 2 months ago by scottmg
Modified:
7 years, 2 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews, wtc
Visibility:
Public.

Description

Disable optimization in prdtoa.c under VS2013. Causes a compiler ICE. Upstream bug marked fixed, so this can be removed on a subsequent compiler release. R=rsleevi@chromium.org BUG=288948

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M README.chromium View 1 1 chunk +3 lines, -0 lines 1 comment Download
M nspr/pr/src/misc/prdtoa.c View 1 chunk +6 lines, -0 lines 0 comments Download
patches/nspr-disable-optimization-2013.patch View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
7 years, 2 months ago (2013-10-11 18:01:15 UTC) #1
Ryan Sleevi
Please add a patch to http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/patches/ +cc wtc, as he's typically the one that rolls ...
7 years, 2 months ago (2013-10-11 18:17:59 UTC) #2
scottmg
On 2013/10/11 18:17:59, Ryan Sleevi wrote: > Please add a patch to > http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/patches/ Done. ...
7 years, 2 months ago (2013-10-11 18:34:28 UTC) #3
Ryan Sleevi
lgtm
7 years, 2 months ago (2013-10-11 18:39:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27011005/9001
7 years, 2 months ago (2013-10-11 18:46:53 UTC) #5
commit-bot: I haz the power
Change committed as 228205
7 years, 2 months ago (2013-10-11 18:47:05 UTC) #6
wtc
7 years, 2 months ago (2013-10-14 19:59:18 UTC) #7
Message was sent while issue was closed.
Patch set 2 LGTM. Thanks.

https://codereview.chromium.org/27011005/diff/9001/README.chromium
File README.chromium (right):

https://codereview.chromium.org/27011005/diff/9001/README.chromium#newcode46
README.chromium:46: - patches/nspr-disable-optimization-2013.patch Disable
optimizations on VS2013

Nit (not worth fixing): the "2013" in the patch file name should be "vs2013".

Powered by Google App Engine
This is Rietveld 408576698