Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 270103002: Revert of New tls channel id version for OpenSSL (Closed)

Created:
6 years, 7 months ago by haavardm
Modified:
6 years, 7 months ago
Reviewers:
wtc, agl, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of New tls channel id version for OpenSSL (https://codereview.chromium.org/259963009/) Reason for revert: I was a little quick committing this. If someone adds another OpenSSL patch and rolls OpenSSL version forward in DEPS the current channel id test will fail on Android, since tls lite has not yet been updated. I'll revert and sync commit and DEPS update with commit of TLS lite. Original issue's description: > New tls channel id version for OpenSSL > > New tls channel id version extracted from patch 0015-channelid.patch attached to http://crbug.com/366961. > > BUG=366961 TBR=wtc@chromium.org,rsleevi@chromium.org,agl@chromium.org NOTREECHECKS=true NOTRY=true BUG=366961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -938 lines) Patch
M openssl/include/openssl/ssl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M openssl/include/openssl/tls1.h View 1 chunk +1 line, -1 line 0 comments Download
D openssl/patches/new_channelid.patch View 1 chunk +0 lines, -273 lines 0 comments Download
M openssl/ssl/s3_clnt.c View 1 chunk +0 lines, -12 lines 0 comments Download
M openssl/ssl/ssl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M openssl/ssl/ssl_locl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M openssl/ssl/t1_enc.c View 1 chunk +35 lines, -61 lines 0 comments Download
M openssl/ssl/t1_lib.c View 2 chunks +0 lines, -37 lines 0 comments Download
M openssl/ssl/tls1.h View 1 chunk +1 line, -1 line 0 comments Download
D patches.chromium/0014-new_channelid.patch View 1 chunk +0 lines, -537 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haavardm
Created Revert of New tls channel id version for OpenSSL
6 years, 7 months ago (2014-05-06 09:00:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/270103002/1
6 years, 7 months ago (2014-05-06 09:00:54 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-06 09:00:55 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-06 09:00:56 UTC) #4
agl
Rubber stamp LGTM for revert.
6 years, 7 months ago (2014-05-06 16:57:19 UTC) #5
agl
The CQ bit was checked by agl@chromium.org
6 years, 7 months ago (2014-05-06 16:57:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/270103002/1
6 years, 7 months ago (2014-05-06 16:57:34 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 16:58:10 UTC) #8
Message was sent while issue was closed.
Change committed as 268540

Powered by Google App Engine
This is Rietveld 408576698