Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2701023002: Add assist to reparent list of Flutter widgets (Closed)

Created:
3 years, 10 months ago by messick
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add assist to reparent a list of Flutter widgets Apparently I forgot to sort the test file, so there's a bit of code rearrangement there. I added the optimization to the filter from the previous CL here, too. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2da528aeac9840a844335cd7f05014ca942d5324

Patch Set 1 #

Patch Set 2 : Change menu label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -66 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 3 chunks +72 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 6 chunks +146 lines, -47 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
messick
3 years, 10 months ago (2017-02-17 18:40:50 UTC) #3
scheglov
LGTM
3 years, 10 months ago (2017-02-17 18:45:35 UTC) #4
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-17 18:50:49 UTC) #5
messick
PTAL I forgot to build and test the new assist in IntelliJ. When I did ...
3 years, 10 months ago (2017-02-17 19:23:05 UTC) #6
scheglov
LGTM
3 years, 10 months ago (2017-02-17 19:36:48 UTC) #7
messick
3 years, 10 months ago (2017-02-17 21:11:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2da528aeac9840a844335cd7f05014ca942d5324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698