components/browser_sync/profile_sync_service.cc - Issue 2701003002: [Sync] Clean up ModelType code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/profile_sync_service.cc

Issue 2701003002: [Sync] Clean up ModelType code. (Closed)

Patch Set: Switched int to size_t to fix compile. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browser_sync/profile_sync_service.cc

diff --git a/components/browser_sync/profile_sync_service.cc b/components/browser_sync/profile_sync_service.cc

index 2909868bc33e3addeee8a618ad28c941de3a26e5..7280c42186b1ad86333af4a3548cc4444a80af1d 100644

--- a/components/browser_sync/profile_sync_service.cc

+++ b/components/browser_sync/profile_sync_service.cc

@@ -1518,7 +1518,9 @@ void ProfileSyncService::UpdateSelectedTypesHistogram(

};

static_assert(39 == syncer::MODEL_TYPE_COUNT,

- "custom config histogram must be updated");

+ "If adding a user selectable type, update "

+ "UserSelectableSyncType in user_selectable_sync_type.h and "

+ "histograms.xml.");

if (!sync_everything) {

const syncer::ModelTypeSet current_types = GetPreferredDataTypes();

« no previous file with comments | « no previous file | components/sync/base/enum_set.h » ('j') | no next file with comments »