Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/sync/driver/model_association_manager.cc

Issue 2701003002: [Sync] Clean up ModelType code. (Closed)
Patch Set: Now with EnumSet tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/sync/base/model_type.h ('K') | « components/sync/base/sync_prefs.cc ('k') | components/sync/driver/user_selectable_sync_type.h » ('j') | components/sync/driver/user_selectable_sync_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/driver/model_association_manager.cc
diff --git a/components/sync/driver/model_association_manager.cc b/components/sync/driver/model_association_manager.cc
index 41d5331534762127986520f62d39ca7b6827208f..3047ab743069daae8b7b3bcee796ba4e716e83d1 100644
--- a/components/sync/driver/model_association_manager.cc
+++ b/components/sync/driver/model_association_manager.cc
@@ -48,8 +48,7 @@ static const ModelType kStartOrder[] = {
static_assert(arraysize(kStartOrder) ==
MODEL_TYPE_COUNT - FIRST_REAL_MODEL_TYPE,
- "kStartOrder must have MODEL_TYPE_COUNT - "
- "FIRST_REAL_MODEL_TYPE elements");
+ "When adding a new type, update kStartOrder.");
// The amount of time we wait for association to finish. If some types haven't
// finished association by the time, DataTypeManager is notified of the
« components/sync/base/model_type.h ('K') | « components/sync/base/sync_prefs.cc ('k') | components/sync/driver/user_selectable_sync_type.h » ('j') | components/sync/driver/user_selectable_sync_type.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698