Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/browser_sync/profile_sync_service.cc

Issue 2701003002: [Sync] Clean up ModelType code. (Closed)
Patch Set: Now with EnumSet tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/base/enum_set.h » ('j') | components/sync/base/enum_set.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/profile_sync_service.cc
diff --git a/components/browser_sync/profile_sync_service.cc b/components/browser_sync/profile_sync_service.cc
index 2909868bc33e3addeee8a618ad28c941de3a26e5..c4153dcf246d39231f755d1cc3804f6eb715266e 100644
--- a/components/browser_sync/profile_sync_service.cc
+++ b/components/browser_sync/profile_sync_service.cc
@@ -1518,7 +1518,9 @@ void ProfileSyncService::UpdateSelectedTypesHistogram(
};
static_assert(39 == syncer::MODEL_TYPE_COUNT,
- "custom config histogram must be updated");
+ "If adding a user selectable type, updated "
pavely 2017/02/23 23:23:03 updated => update
skym 2017/02/24 18:59:07 Done.
+ "UserSelectableSyncType in user_selectable_sync_type.h and "
+ "histograms.xml.");
if (!sync_everything) {
const syncer::ModelTypeSet current_types = GetPreferredDataTypes();
« no previous file with comments | « no previous file | components/sync/base/enum_set.h » ('j') | components/sync/base/enum_set.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698