[Sync] Clean up ModelType code.

components/sync/base/sync_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/base/sync_prefs.h"
 
 #include "base/base64.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
@@ skipping 234 matching lines @@
   DCHECK(CalledOnValidThread());
   return pref_service_->GetString(prefs::kSyncSessionsGUID);
 }
 
 void SyncPrefs::SetSyncSessionsGUID(const std::string& guid) {
   DCHECK(CalledOnValidThread());
   pref_service_->SetString(prefs::kSyncSessionsGUID, guid);
 }
 
 // static
-const char* SyncPrefs::GetPrefNameForDataType(ModelType data_type) {
-  switch (data_type) {
+const char* SyncPrefs::GetPrefNameForDataType(ModelType type) {
+  switch (type) {
+    case UNSPECIFIED:
+    case TOP_LEVEL_FOLDER:
+      break;
     case BOOKMARKS:
       return prefs::kSyncBookmarks;
+    case PREFERENCES:
+      return prefs::kSyncPreferences;
     case PASSWORDS:
       return prefs::kSyncPasswords;
-    case PREFERENCES:
-      return prefs::kSyncPreferences;
+    case AUTOFILL_PROFILE:
+      return prefs::kSyncAutofillProfile;
     case AUTOFILL:
       return prefs::kSyncAutofill;
-    case AUTOFILL_PROFILE:
-      return prefs::kSyncAutofillProfile;
     case AUTOFILL_WALLET_DATA:
       return prefs::kSyncAutofillWallet;
     case AUTOFILL_WALLET_METADATA:
       return prefs::kSyncAutofillWalletMetadata;
     case THEMES:
       return prefs::kSyncThemes;
     case TYPED_URLS:
       return prefs::kSyncTypedUrls;
-    case EXTENSION_SETTINGS:
-      return prefs::kSyncExtensionSettings;
     case EXTENSIONS:
       return prefs::kSyncExtensions;
-    case APP_LIST:
-      return prefs::kSyncAppList;
-    case APP_SETTINGS:
-      return prefs::kSyncAppSettings;
-    case APPS:
-      return prefs::kSyncApps;
     case SEARCH_ENGINES:
       return prefs::kSyncSearchEngines;
     case SESSIONS:
       return prefs::kSyncSessions;
+    case APPS:
+      return prefs::kSyncApps;
+    case APP_SETTINGS:
+      return prefs::kSyncAppSettings;
+    case EXTENSION_SETTINGS:
+      return prefs::kSyncExtensionSettings;
     case APP_NOTIFICATIONS:
       return prefs::kSyncAppNotifications;
     case HISTORY_DELETE_DIRECTIVES:
       return prefs::kSyncHistoryDeleteDirectives;
     case SYNCED_NOTIFICATIONS:
       return prefs::kSyncSyncedNotifications;
     case SYNCED_NOTIFICATION_APP_INFO:
       return prefs::kSyncSyncedNotificationAppInfo;
     case DICTIONARY:
       return prefs::kSyncDictionary;
     case FAVICON_IMAGES:
       return prefs::kSyncFaviconImages;
     case FAVICON_TRACKING:
       return prefs::kSyncFaviconTracking;
+    case DEVICE_INFO:
+      return prefs::kSyncDeviceInfo;
+    case PRIORITY_PREFERENCES:
+      return prefs::kSyncPriorityPreferences;
     case SUPERVISED_USER_SETTINGS:
       return prefs::kSyncSupervisedUserSettings;
-    case PROXY_TABS:
-      return prefs::kSyncTabs;
-    case PRIORITY_PREFERENCES:
-      return prefs::kSyncPriorityPreferences;
     case SUPERVISED_USERS:
       return prefs::kSyncSupervisedUsers;
+    case SUPERVISED_USER_SHARED_SETTINGS:
+      return prefs::kSyncSupervisedUserSharedSettings;
     case ARTICLES:
       return prefs::kSyncArticles;
-    case SUPERVISED_USER_SHARED_SETTINGS:
-      return prefs::kSyncSupervisedUserSharedSettings;
+    case APP_LIST:
+      return prefs::kSyncAppList;
+    case WIFI_CREDENTIALS:
+      return prefs::kSyncWifiCredentials;
     case SUPERVISED_USER_WHITELISTS:
       return prefs::kSyncSupervisedUserWhitelists;
-    case DEVICE_INFO:
-      return prefs::kSyncDeviceInfo;
-    case WIFI_CREDENTIALS:
-      return prefs::kSyncWifiCredentials;
     case ARC_PACKAGE:
       return prefs::kSyncArcPackage;
     case PRINTERS:
       return prefs::kSyncPrinters;
     case READING_LIST:
       return prefs::kSyncReadingList;
-    default:
+    case PROXY_TABS:
+      return prefs::kSyncTabs;
+    case NIGORI:
+    case EXPERIMENTS:
+    case MODEL_TYPE_COUNT:
       break;
   }
-  NOTREACHED() << "Type is " << data_type;
+  NOTREACHED() << "No pref mapping for type " << ModelTypeToString(type);
   return nullptr;
 }
 
 #if defined(OS_CHROMEOS)
 std::string SyncPrefs::GetSpareBootstrapToken() const {
   DCHECK(CalledOnValidThread());
   return pref_service_->GetString(prefs::kSyncSpareBootstrapToken);
 }
 
 void SyncPrefs::SetSpareBootstrapToken(const std::string& token) {
@@ skipping 227 matching lines @@
     // TODO(pastarmovj): Quick and dirty solution for stage 1 of crbug/694464
     // for merging back into Chrome 57.
     local_sync_backend_folder = local_sync_backend_folder.Append(
         FILE_PATH_LITERAL("Google/Chrome/User Data"));
   }
 #endif  // defined(OS_WIN)
   return local_sync_backend_folder;
 }
 
 }  // namespace syncer