Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2700943005: Update clang-format binaries and scripts for all platforms. (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
Nico
CC:
Ryan Hamilton
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Update clang-format binaries and scripts for all platforms. I followed these instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_format_binaries.md The binaries were built at clang revision 293675 on Fri Feb 17 17:17:17 PST 2017. Results/diagnostics on clang-format binaries: -> old/current: https://codereview.chromium.org/2700123003/ -> new: https://codereview.chromium.org/2701993002/ Also checked that the uploaded Mac and Linux binaries have the executable bit and that Mac binary is targeting OSX 10.9. BUG=567770 R=thakis@chromium.org Committed: 7e53759cf4e553e3a51b5c97420da022cc83de44

Patch Set 1 : no dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M clang_format/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M linux64/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mac/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M win/clang-format.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Dan Beam
3 years, 10 months ago (2017-02-18 01:52:35 UTC) #3
Nico
lgtm
3 years, 10 months ago (2017-02-19 23:38:46 UTC) #5
Dan Beam
3 years, 10 months ago (2017-02-21 19:18:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
7e53759cf4e553e3a51b5c97420da022cc83de44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698