Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 27009005: Generate HTMLElementFactory with Python (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Generate HTMLElementFactory with Python This CL replaces the old Perl-based HTMLElementFactory with a Python implementation based in jinja2 templates. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159952

Patch Set 1 #

Patch Set 2 : Builds #

Patch Set 3 : remove suprious change #

Patch Set 4 : Actually use the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -20 lines) Patch
A Source/build/scripts/make_element_factory.py View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
M Source/build/scripts/make_names.pl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/make_qualified_names.py View 1 chunk +17 lines, -17 lines 0 comments Download
M Source/build/scripts/name_utilities.py View 1 chunk +7 lines, -0 lines 0 comments Download
A Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download
A Source/build/scripts/templates/ElementFactory.h.tmpl View 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/core_derived_sources.gyp View 1 2 3 2 chunks +20 lines, -2 lines 0 comments Download
A Source/core/html/HTMLContentElement.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/html/HTMLShadowElement.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
Ready for review.
7 years, 2 months ago (2013-10-15 21:49:33 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-15 21:53:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/27009005/6001
7 years, 2 months ago (2013-10-15 21:54:37 UTC) #3
abarth-chromium
Turns out this was only a few inches from actually working, so I've tweaked a ...
7 years, 2 months ago (2013-10-15 22:34:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/27009005/17001
7 years, 2 months ago (2013-10-15 22:39:54 UTC) #5
abarth-chromium
Committed patchset #4 manually as r159702 (presubmit successful).
7 years, 2 months ago (2013-10-16 00:15:13 UTC) #6
abarth-chromium
7 years, 2 months ago (2013-10-18 16:01:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r159952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698