chrome/browser/resources/settings/search_engines_page/search_engine_entry.js - Issue 2700863002: MD Settings: adjust focus-outline behaviors on search engine iron-list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 2700863002: MD Settings: adjust focus-outline behaviors on search engine iron-list. (Closed)

Patch Set: use polymer's listeners property instead of addEventListener Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

index 5e026d6e06927841b27e5c5c828164514f8ebea0..7a1fe987f457e14ed591bde1ccda4be509c97cfb 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

@@ -9,6 +9,8 @@

Polymer({

is: 'settings-search-engine-entry',

+ behaviors: [FocusableIronListItemBehavior],

properties: {

/** @type {!SearchEngine} */

engine: Object,

@@ -33,6 +35,7 @@ Polymer({

showEditSearchEngineDialog_: Boolean,

hcarmona 2017/02/17 23:35:37 nit: remove the \n

scottchen 2017/02/22 07:07:06 Done.

/** @private {settings.SearchEnginesBrowserProxy} */

browserProxy_: null,