Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: pkg/analyzer/lib/src/summary/format.dart

Issue 2700843002: Use absolute URIs for LinkedDependency.uri/parts. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/format.dart
diff --git a/pkg/analyzer/lib/src/summary/format.dart b/pkg/analyzer/lib/src/summary/format.dart
index 9ad6c5c77c160756a34445e732d5b4ea43ba864a..c86b37cf40df476580d132ffdb34cdb76e7afd58 100644
--- a/pkg/analyzer/lib/src/summary/format.dart
+++ b/pkg/analyzer/lib/src/summary/format.dart
@@ -2114,8 +2114,8 @@ class LinkedDependencyBuilder extends Object with _LinkedDependencyMixin impleme
List<String> get parts => _parts ??= <String>[];
/**
- * URI for the compilation units listed in the library's `part` declarations.
- * These URIs are relative to the importing library.
+ * Absolute URI for the compilation units listed in the library's `part`
+ * declarations, empty string for invalid URI.
*/
void set parts(List<String> value) {
this._parts = value;
@@ -2125,11 +2125,7 @@ class LinkedDependencyBuilder extends Object with _LinkedDependencyMixin impleme
String get uri => _uri ??= '';
/**
- * The relative URI of the dependent library. This URI is relative to the
- * importing library, even if there are intervening `export` declarations.
- * So, for example, if `a.dart` imports `b/c.dart` and `b/c.dart` exports
- * `d/e.dart`, the URI listed for `a.dart`'s dependency on `e.dart` will be
- * `b/d/e.dart`.
+ * The absolute URI of the dependent library, e.g. `package:foo/bar.dart`.
*/
void set uri(String value) {
this._uri = value;

Powered by Google App Engine
This is Rietveld 408576698