Use absolute URIs for LinkedDependency.uri/parts.

Use absolute URIs for LinkedDependency.uri/parts.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f224ebda5c476773aa3bd614b8be8bd566cd1e21

[Paul Berry, 2017-02-16 22:17:50]

lgtm

https://codereview.chromium.org/2700843002/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_server.iml (right):

https://codereview.chromium.org/2700843002/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_server.iml:59: <orderEntry type="library"
name="Dart Packages" level="project" />
I believe this should be reverted, since it's a side effect of the version of
IntelliJ you're running.

https://codereview.chromium.org/2700843002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/2700843002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:226: final Map<String, int>
uriToDependency = <String, int>{};
I don't understand this change.  Why don't we need to map null->0 anymore?

Similar question about dependencyToPublicNamespace.

[scheglov, 2017-02-16 22:32:36]

https://codereview.chromium.org/2700843002/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_server.iml (right):

https://codereview.chromium.org/2700843002/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_server.iml:59: <orderEntry type="library"
name="Dart Packages" level="project" />
On 2017/02/16 22:17:50, Paul Berry wrote:
> I believe this should be reverted, since it's a side effect of the version of
> IntelliJ you're running.

Done.

https://codereview.chromium.org/2700843002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/2700843002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:226: final Map<String, int>
uriToDependency = <String, int>{};
On 2017/02/16 22:17:50, Paul Berry wrote:
> I don't understand this change.  Why don't we need to map null->0 anymore?
> 
> Similar question about dependencyToPublicNamespace.

computeExportNamespace() needs to use absolute URI so that relative URIs in
UnlinkedExportPublic can be resolved. We also don't need to shy of using the URI
of the library being linked if we make all other dependencies absolute.

[Paul Berry, 2017-02-16 22:55:26]

lgtm

https://codereview.chromium.org/2700843002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/prelink.dart (right):

https://codereview.chromium.org/2700843002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/prelink.dart:226: final Map<String, int>
uriToDependency = <String, int>{};
On 2017/02/16 22:32:36, scheglov wrote:
> On 2017/02/16 22:17:50, Paul Berry wrote:
> > I don't understand this change.  Why don't we need to map null->0 anymore?
> > 
> > Similar question about dependencyToPublicNamespace.
> 
> computeExportNamespace() needs to use absolute URI so that relative URIs in
> UnlinkedExportPublic can be resolved. We also don't need to shy of using the
URI
> of the library being linked if we make all other dependencies absolute.

Ok, thanks.

[scheglov, 2017-02-16 22:59:20]

Description was changed from

==========
Use absolute URIs for LinkedDependency.uri/parts.

R=paulberry@google.com
BUG=
==========

to

==========
Use absolute URIs for LinkedDependency.uri/parts.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f224ebda5c476773aa3bd614b8be8bd566cd1e21
==========

[scheglov, 2017-02-16 22:59:22]

Committed patchset #1 (id:1) manually as
f224ebda5c476773aa3bd614b8be8bd566cd1e21 (presubmit successful).