third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html - Issue 2700823002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html

Issue 2700823002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Patch Set: Addressing comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html b/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html

index 314268f6376fb61554aea63846ad36bb26a0e858..87f23621d23e3812d51a3b62548352aa9ff5b10b 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html

@@ -1,17 +1,20 @@

-<!DOCTYPE HTML>

-<p>This test passes by not crashing.</p>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

</canvas>

-if (window.testRunner)

- testRunner.dumpAsText();

+test(function(t) {

-var button = document.getElementById("button");

-button.focus();

-var canvas = document.getElementById("canvas")

-var ctx = canvas.getContext("2d");

-ctx.rect(0, 0, 10, 10);

-canvas.style.display = "none";

-ctx.drawFocusIfNeeded(button);

-</script>

+ var button = document.getElementById("button");

+ button.focus();

+ var canvas = document.getElementById("canvas")

+ var ctx = canvas.getContext("2d");

+ ctx.rect(0, 0, 10, 10);

+ canvas.style.display = "none";

+ ctx.drawFocusIfNeeded(button);

+}, 'Test that drawFocusIfNeeded does not crash.');

+</script>