Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 2700813002: [V8] Implement SIMD Boolean vector types to allow mask registers. (Closed)
Patch Set: Remove stray DCHECK. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/x64/instruction-selector-x64.cc
diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc
index 9a93b9450a440de816e266662d1a43c1c685aba1..33a35c1067f7fb91235e43eafc4e35f6bad63728 100644
--- a/src/compiler/x64/instruction-selector-x64.cc
+++ b/src/compiler/x64/instruction-selector-x64.cc
@@ -220,6 +220,9 @@ ArchOpcode GetLoadOpcode(LoadRepresentation load_rep) {
opcode = kX64Movq;
break;
case MachineRepresentation::kSimd128: // Fall through.
+ case MachineRepresentation::kSimdBool4: // Fall through.
+ case MachineRepresentation::kSimdBool8: // Fall through.
+ case MachineRepresentation::kSimdBool16: // Fall through.
case MachineRepresentation::kNone:
UNREACHABLE();
break;
@@ -252,6 +255,9 @@ ArchOpcode GetStoreOpcode(StoreRepresentation store_rep) {
return kX64Movq;
break;
case MachineRepresentation::kSimd128: // Fall through.
+ case MachineRepresentation::kSimdBool4: // Fall through.
+ case MachineRepresentation::kSimdBool8: // Fall through.
+ case MachineRepresentation::kSimdBool16: // Fall through.
case MachineRepresentation::kNone:
UNREACHABLE();
return kArchNop;
@@ -399,6 +405,9 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
break;
case MachineRepresentation::kBit: // Fall through.
case MachineRepresentation::kSimd128: // Fall through.
+ case MachineRepresentation::kSimdBool4: // Fall through.
+ case MachineRepresentation::kSimdBool8: // Fall through.
+ case MachineRepresentation::kSimdBool16: // Fall through.
case MachineRepresentation::kTaggedSigned: // Fall through.
case MachineRepresentation::kTaggedPointer: // Fall through.
case MachineRepresentation::kTagged: // Fall through.
@@ -454,6 +463,9 @@ void InstructionSelector::VisitCheckedStore(Node* node) {
break;
case MachineRepresentation::kBit: // Fall through.
case MachineRepresentation::kSimd128: // Fall through.
+ case MachineRepresentation::kSimdBool4: // Fall through.
+ case MachineRepresentation::kSimdBool8: // Fall through.
+ case MachineRepresentation::kSimdBool16: // Fall through.
case MachineRepresentation::kTaggedSigned: // Fall through.
case MachineRepresentation::kTaggedPointer: // Fall through.
case MachineRepresentation::kTagged: // Fall through.

Powered by Google App Engine
This is Rietveld 408576698