Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2700763002: On safari, isContentEditable_A02_t01 doesn't always fail (Closed)

Created:
3 years, 10 months ago by jensj
Modified:
3 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

On safari, isContentEditable_A02_t01 doesn't always fail It sometimes pass --- see dart2js-mac10.11-safari-2-3-be/builds/3844/ dart2js-mac10.11-safari-2-3-be/builds/3892/ dart2js-mac10.11-safari-2-3-be/builds/3897/ BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/fa237446285bfd1ca1b9beab3200055363574bbe

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with issue number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/co19/co19-dart2js.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 10 months ago (2017-02-16 12:40:25 UTC) #2
asgerf
lgtm https://codereview.chromium.org/2700763002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2700763002/diff/1/tests/co19/co19-dart2js.status#newcode4900 tests/co19/co19-dart2js.status:4900: +LibTest/html/Element/isContentEditable_A02_t01: Pass, RuntimeError # Fails 10 out of ...
3 years, 10 months ago (2017-02-16 12:42:20 UTC) #3
jensj
3 years, 10 months ago (2017-02-16 12:47:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fa237446285bfd1ca1b9beab3200055363574bbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698