[inspector] extend protocol for code coverage.

src/inspector/v8-runtime-agent-impl.cc

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "src/inspector/v8-runtime-agent-impl.h"
 
+#include "src/debug/debug-interface.h"
 #include "src/inspector/injected-script.h"
 #include "src/inspector/inspected-context.h"
 #include "src/inspector/protocol/Protocol.h"
 #include "src/inspector/remote-object-id.h"
 #include "src/inspector/string-util.h"
 #include "src/inspector/v8-console-message.h"
 #include "src/inspector/v8-debugger-agent-impl.h"
 #include "src/inspector/v8-debugger.h"
 #include "src/inspector/v8-inspector-impl.h"
 #include "src/inspector/v8-inspector-session-impl.h"
@@ skipping 595 matching lines @@
   }
   ProtocolPromiseHandler<RunScriptCallback>::add(
       m_inspector, scope.context(), maybeResultValue.ToLocalChecked(),
       "Result of the script execution is not a promise",
       m_session->contextGroupId(),
       scope.injectedScript()->context()->contextId(), objectGroup.fromMaybe(""),
       returnByValue.fromMaybe(false), generatePreview.fromMaybe(false),
       std::move(callback));
 }
 
+Response V8RuntimeAgentImpl::startPreciseCoverage() {
+  v8::debug::Coverage::TogglePrecise(m_inspector->isolate(), true);

[kozy, 2017/02/16 16:47:19]

We can be prepared for more then one runtime agent (bright future with multi
client support) and implement togglePrecise on V8Debugger and store counter
there. Like we do for enable/disable [1].

[1]
https://cs.chromium.org/chromium/src/v8/src/inspector/v8-debugger.cc?rcl=6346...

[Yang, 2017/02/20 11:24:42]

Done.

+  return Response::OK();
+}
+
+Response V8RuntimeAgentImpl::stopPreciseCoverage() {
+  v8::debug::Coverage::TogglePrecise(m_inspector->isolate(), false);

[kozy, 2017/02/16 16:47:19]

- please toggle precise off in V8RuntimeAgentImpl::disable,
- and we need to support provisional precise coverage on page reload - it means
that you need to store precise state in m_state, e.g.
customObjectFormatterEnabled, and restore it in V8RuntimeAgentImpl::restore.

[Yang, 2017/02/20 11:24:42]

Done.

+  return Response::OK();
+}
+
+namespace {
+std::unique_ptr<protocol::Runtime::CoverageRange> CreateCoverageRange(

[kozy, 2017/02/16 16:47:19]

We still use not V8 code style here, let's don't mix code styles until we move
everything to new one - createCoverageRange.

[Yang, 2017/02/20 11:24:42]

Acknowledged.

+    v8::debug::Coverage::Range range) {
+  std::unique_ptr<protocol::Array<protocol::Runtime::CoverageRange>> nested =
+      protocol::Array<protocol::Runtime::CoverageRange>::create();
+  for (size_t i = 0; i < range.NestedCount(); i++) {
+    nested->addItem(CreateCoverageRange(range.GetNested(i)));
+  }
+  return protocol::Runtime::CoverageRange::create()
+      .setFunctionName(
+          toProtocolString(range.Name().FromMaybe(v8::Local<v8::String>())))
+      .setStartLineNumber(range.Start().GetLineNumber())
+      .setStartColumnNumber(range.Start().GetColumnNumber())
+      .setEndLineNumber(range.End().GetLineNumber())
+      .setEndColumnNumber(range.End().GetColumnNumber())
+      .setNested(std::move(nested))
+      .setCount(range.Count())
+      .build();
+}
+}  // anonymous namespace
+
+Response V8RuntimeAgentImpl::collectCoverage(
+    std::unique_ptr<protocol::Array<protocol::Runtime::ScriptCoverage>>*
+        out_result) {
+  std::unique_ptr<protocol::Array<protocol::Runtime::ScriptCoverage>> result =
+      protocol::Array<protocol::Runtime::ScriptCoverage>::create();
+  v8::HandleScope handle_scope(m_inspector->isolate());
+  v8::debug::Coverage coverage =
+      v8::debug::Coverage::Collect(m_inspector->isolate());
+  for (size_t i = 0; i < coverage.ScriptCount(); i++) {
+    v8::Local<v8::debug::Script> script = coverage.GetScript(i);
+    String16 url;
+    v8::Local<v8::String> name;
+    if (script->Name().ToLocal(&name) || script->SourceURL().ToLocal(&name)) {
+      url = toProtocolString(name);
+    }
+    result->addItem(protocol::Runtime::ScriptCoverage::create()
+                        .setScriptId(String16::fromInteger(script->Id()))
+                        .setUrl(url)
+                        .setToplevel(CreateCoverageRange(coverage.GetRange(i)))
+                        .build());
+  }
+  *out_result = std::move(result);
+  return Response::OK();
+}
+
 void V8RuntimeAgentImpl::restore() {
   if (!m_state->booleanProperty(V8RuntimeAgentImplState::runtimeEnabled, false))
     return;
   m_frontend.executionContextsCleared();
   enable();
   if (m_state->booleanProperty(
           V8RuntimeAgentImplState::customObjectFormatterEnabled, false))
     m_session->setCustomObjectFormatterEnabled(true);
 }
 
@@ skipping 72 matching lines @@
 }
 
 bool V8RuntimeAgentImpl::reportMessage(V8ConsoleMessage* message,
                                        bool generatePreview) {
   message->reportToFrontend(&m_frontend, m_session, generatePreview);
   m_frontend.flush();
   return m_inspector->hasConsoleMessageStorage(m_session->contextGroupId());
 }
 
 }  // namespace v8_inspector