third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h - Issue 2700683002: [LayoutNG] Fix incorrectly positioned empty blocks inside of new BFC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

Issue 2700683002: [LayoutNG] Fix incorrectly positioned empty blocks inside of new BFC (Closed)

Patch Set: Fix comments and some crashes in FloatingObjects Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

index 5c157e3030736ec256a9a8e199e541e9bf609da6..2ccd3e5eb70743247be4501e0d623c5b77675332 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

@@ -66,6 +66,11 @@ class CORE_EXPORT NGPhysicalFragment : public RefCounted<NGPhysicalFragment> {

return offset_.top;

}

+ NGPhysicalOffset Offset() const {

+ DCHECK(is_placed_);

+ return offset_;

+ }

// Should only be used by the parent fragement's layout.

void SetOffset(NGPhysicalOffset offset) {

DCHECK(!is_placed_);