Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_units.cc

Issue 2700683002: [LayoutNG] Fix incorrectly positioned empty blocks inside of new BFC (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_units.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_units.cc b/third_party/WebKit/Source/core/layout/ng/ng_units.cc
index 68c50314d995c920476c492b0fa3bb3d65ac5b74..996d266f431fdf2c66ef8a22c9db6f0448408632 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_units.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_units.cc
@@ -100,6 +100,10 @@ NGPhysicalOffset NGLogicalOffset::ConvertToPhysical(
}
}
+bool NGPhysicalOffset::operator==(const NGPhysicalOffset& other) const {
ikilpatrick 2017/02/16 17:27:38 .nit move to after NGPhysicalOffset::operator-= ?
Gleb Lanbin 2017/02/16 20:08:27 Done.
+ return other.left == left && other.top == top;
+}
+
bool NGLogicalOffset::operator==(const NGLogicalOffset& other) const {
return std::tie(other.inline_offset, other.block_offset) ==
std::tie(inline_offset, block_offset);

Powered by Google App Engine
This is Rietveld 408576698