Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2700673004: Windows: VirtualFree with MEM_RELEASE wants 0 instead of the region's size. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Windows: VirtualFree with MEM_RELEASE wants 0 instead of the region's size. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/1392108dead56e71e50a367c476a6f93cdbeedd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/file_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-16 23:38:14 UTC) #2
zra
lgtm
3 years, 10 months ago (2017-02-16 23:39:36 UTC) #3
rmacnak
3 years, 10 months ago (2017-02-16 23:43:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1392108dead56e71e50a367c476a6f93cdbeedd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698