third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h - Issue 2700663002: Adds keyboard functionality for videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)

Patch Set: Addresses mlamouri's #20 comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('j') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

index 0edf390865931e132d8d537fd0f07335c5c9bb05..aa20893b1bd127e0922a1d1bfcfe69156836eb3a 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

@@ -125,6 +125,7 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,

void onLoadedMetadata() override;

void onEnteredFullscreen() override;

void onExitedFullscreen() override;

+ void onMediaKeyboardEvent(Event* event) { defaultEventHandler(event); }

Document& ownerDocument() { return document(); }

DECLARE_VIRTUAL_TRACE();