third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h - Issue 2700663002: Adds keyboard functionality for videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)

Patch Set: Add spatial nav check. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp ('K') | « third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

index 1bb2b658c895001bffb37081e38a2b508caee8d5..2e3c434bd612cad2f02e34f71556756cc12e258b 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h

@@ -23,6 +23,8 @@ class MediaControlVolumeSliderElement final : public MediaControlInputElement {

bool WillRespondToMouseMoveEvents() override;

bool WillRespondToMouseClickEvents() override;

+ void OnMediaKeyboardEvent(Event* event) { DefaultEventHandler(event); }

private:

void DefaultEventHandler(Event*) override;

bool KeepEventInNode(Event*) override;