Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)
Patch Set: Addresses mlamouri's #11 comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
index df272a9493bee9dd77330ad7c5154beb82b50715..a7068637f744acba8fddd3f2c045c8a505080ed3 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
@@ -120,10 +120,10 @@ class MediaControlPlayButtonElement final : public MediaControlInputElement {
bool hasOverflowButton() override { return true; }
+ void defaultEventHandler(Event*) override;
+
private:
explicit MediaControlPlayButtonElement(MediaControls&);
-
- void defaultEventHandler(Event*) override;
};
// ----------------------------
@@ -273,10 +273,11 @@ class MediaControlTimelineElement final : public MediaControlInputElement {
void setPosition(double);
void setDuration(double);
+ void defaultEventHandler(Event*) override;
+
private:
explicit MediaControlTimelineElement(MediaControls&);
- void defaultEventHandler(Event*) override;
bool keepEventInNode(Event*) override;
};
@@ -354,10 +355,11 @@ class MediaControlVolumeSliderElement final : public MediaControlInputElement {
bool willRespondToMouseClickEvents() override;
void setVolume(double);
+ void defaultEventHandler(Event*) override;
+
private:
explicit MediaControlVolumeSliderElement(MediaControls&);
- void defaultEventHandler(Event*) override;
bool keepEventInNode(Event*) override;
};

Powered by Google App Engine
This is Rietveld 408576698