third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h - Issue 2700663002: Adds keyboard functionality for videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)

Patch Set: Forgot the test. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.h ('k') | third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h

index ea412ba606c2ee627a3913f30a50a90791a25800..9f3034ce664d8f7825b13bd73ae7a3e1012087c8 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h

@@ -27,6 +27,8 @@ class MediaControlTimelineElement final : public MediaControlInputElement {

void OnPlaying();

+ void OnMediaKeyboardEvent(Event* event) { DefaultEventHandler(event); }

private:

void DefaultEventHandler(Event*) override;

bool KeepEventInNode(Event*) override;