Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp

Issue 2700663002: Adds keyboard functionality for videos. (Closed)
Patch Set: Forgot the test. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
index 69df9e8bafcf4867f77b9aeae4ea6d1eaa3c805d..093d15ca4e1078b9a20128212983d74348bcb95b 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
@@ -35,6 +35,9 @@ void MediaControlsMediaEventListener::Attach() {
GetMediaElement().addEventListener(EventTypeNames::error, this, false);
GetMediaElement().addEventListener(EventTypeNames::loadedmetadata, this,
false);
+ GetMediaElement().addEventListener(EventTypeNames::keypress, this, false);
+ GetMediaElement().addEventListener(EventTypeNames::keydown, this, false);
+ GetMediaElement().addEventListener(EventTypeNames::keyup, this, false);
// Listen to two different fullscreen events in order to make sure the new and
// old APIs are handled.
@@ -181,8 +184,16 @@ void MediaControlsMediaEventListener::handleEvent(
// Keypress events.
if (event->type() == EventTypeNames::keypress) {
- if (event->currentTarget() == media_controls_->PanelElement())
+ if (event->currentTarget() == media_controls_->PanelElement()) {
media_controls_->OnPanelKeypress();
+ return;
+ }
+ }
+
+ if (event->type() == EventTypeNames::keypress ||
+ event->type() == EventTypeNames::keydown ||
+ event->type() == EventTypeNames::keyup) {
+ media_controls_->OnMediaKeyboardEvent(event);
return;
}

Powered by Google App Engine
This is Rietveld 408576698