Adds keyboard functionality for videos.

third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 15 matching lines @@
 
 #include "modules/media_controls/MediaControlsImpl.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/ClientRect.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/ResizeObserver.h"
 #include "core/dom/ResizeObserverCallback.h"
 #include "core/dom/ResizeObserverEntry.h"
 #include "core/dom/TaskRunnerHelper.h"
+#include "core/events/KeyboardEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/html/media/HTMLMediaElementControlsList.h"
 #include "core/html/shadow/MediaControlsMediaEventListener.h"
 #include "core/html/shadow/MediaControlsWindowEventListener.h"
 #include "core/html/track/TextTrackContainer.h"
 #include "core/html/track/TextTrackList.h"
@@ skipping 712 matching lines @@
   }
 
   if (event->type() == EventTypeNames::mousemove) {
     // When we get a mouse move, show the media controls, and start a timer
     // that will hide the media controls after a 3 seconds without a mouse move.
     makeOpaque();
     if (shouldHideMediaControls(IgnoreVideoHover))
       startHideMediaControlsTimer();
     return;
   }
+
+  if (event->type() == EventTypeNames::input) {
+    resetHideMediaControlsTimer();
+  }

[mlamouri (slow - plz ping), 2017/04/10 13:14:02]

I think steimel@'s CL doing this has landed.

[CJ, 2017/04/12 23:21:05]

Done.

[CJ, 2017/04/12 23:21:05]

Done.

+
+  if (event->isKeyboardEvent()) {
+    const String& key = toKeyboardEvent(event)->key();
+    if (key == "Enter" || toKeyboardEvent(event)->keyCode() == ' ') {
+      m_playButton->onMediaKeyboardEvent(event);
+      return;
+    }
+    if (key == "ArrowLeft" || key == "ArrowRight" || key == "Home" ||
+        key == "End") {
+      timelineElement()->onMediaKeyboardEvent(event);

[mlamouri (slow - plz ping), 2017/04/10 13:14:02]

nit: use the member directly

[CJ, 2017/04/12 23:21:05]

Done.

+      return;
+    }
+    if (key == "ArrowDown" || key == "ArrowUp") {
+      volumeSliderElement()->onMediaKeyboardEvent(event);

[mlamouri (slow - plz ping), 2017/04/10 13:14:02]

ditto

[CJ, 2017/04/12 23:21:05]

Done.

+      return;
+    }
+  }
 }
 
 void MediaControlsImpl::hideMediaControlsTimerFired(TimerBase*) {
   unsigned behaviorFlags =
       m_hideTimerBehaviorFlags | IgnoreFocus | IgnoreVideoHover;
   m_hideTimerBehaviorFlags = IgnoreNone;
   m_keepShowingUntilTimerFires = false;
 
   if (mediaElement().paused())
     return;
@@ skipping 337 matching lines @@
   visitor->trace(m_castButton);
   visitor->trace(m_overlayCastButton);
   visitor->trace(m_mediaEventListener);
   visitor->trace(m_windowEventListener);
   visitor->trace(m_orientationLockDelegate);
   MediaControls::trace(visitor);
   HTMLDivElement::trace(visitor);
 }
 
 }  // namespace blink