Adds keyboard functionality for videos.

third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/shadow/MediaControlsMediaEventListener.h"
 
 #include "core/events/Event.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/shadow/MediaControls.h"
 #include "core/html/track/TextTrackList.h"
@@ skipping 11 matching lines @@
   DCHECK(mediaElement().isConnected());
 
   mediaElement().addEventListener(EventTypeNames::volumechange, this, false);
   mediaElement().addEventListener(EventTypeNames::focusin, this, false);
   mediaElement().addEventListener(EventTypeNames::timeupdate, this, false);
   mediaElement().addEventListener(EventTypeNames::play, this, false);
   mediaElement().addEventListener(EventTypeNames::pause, this, false);
   mediaElement().addEventListener(EventTypeNames::durationchange, this, false);
   mediaElement().addEventListener(EventTypeNames::error, this, false);
   mediaElement().addEventListener(EventTypeNames::loadedmetadata, this, false);
+  mediaElement().addEventListener(EventTypeNames::keypress, this, false);
+  mediaElement().addEventListener(EventTypeNames::keydown, this, false);
+  mediaElement().addEventListener(EventTypeNames::keyup, this, false);

[mlamouri (slow - plz ping), 2017/03/27 13:02:12]

I think keypress should be enough here.

[CJ, 2017/04/08 00:31:27]

Keypress only works for the Enter button. All other controls are not registered.
Need to check if keyup has any baring in the blue line error once the fix for
that makes its way into the repo.

 
   // Listen to two different fullscreen events in order to make sure the new and
   // old APIs are handled.
   mediaElement().addEventListener(EventTypeNames::webkitfullscreenchange, this,
                                   false);
   m_mediaControls->document().addEventListener(EventTypeNames::fullscreenchange,
                                                this, false);
 
   // TextTracks events.
   TextTrackList* textTracks = mediaElement().textTracks();
@@ skipping 73 matching lines @@
   if (event->type() == EventTypeNames::addtrack ||
       event->type() == EventTypeNames::removetrack) {
     m_mediaControls->onTextTracksAddedOrRemoved();
     return;
   }
   if (event->type() == EventTypeNames::change) {
     m_mediaControls->onTextTracksChanged();
     return;
   }
 
+  if (event->type() == EventTypeNames::keypress || EventTypeNames::keydown ||
+      EventTypeNames::keyup) {

[mlamouri (slow - plz ping), 2017/03/27 13:02:12]

ditto

[CJ, 2017/04/08 00:31:27]

Acknowledged.

+    m_mediaControls->onMediaKeypress(event);
+    return;
+  }
+
   NOTREACHED();
 }
 
 DEFINE_TRACE(MediaControlsMediaEventListener) {
   EventListener::trace(visitor);
   visitor->trace(m_mediaControls);
 }
 
 }  // namespace blink