Adds keyboard functionality for videos.

third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 15 matching lines @@
 
 #include "core/html/shadow/MediaControls.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/ClientRect.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/ResizeObserver.h"
 #include "core/dom/ResizeObserverCallback.h"
 #include "core/dom/ResizeObserverEntry.h"
 #include "core/dom/TaskRunnerHelper.h"
+#include "core/events/KeyboardEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/html/shadow/MediaControlsMediaEventListener.h"
 #include "core/html/shadow/MediaControlsOrientationLockDelegate.h"
 #include "core/html/shadow/MediaControlsWindowEventListener.h"
 #include "core/html/track/TextTrackContainer.h"
 #include "core/html/track/TextTrackList.h"
@@ skipping 698 matching lines @@
   }
 
   if (event->type() == EventTypeNames::mousemove) {
     // When we get a mouse move, show the media controls, and start a timer
     // that will hide the media controls after a 3 seconds without a mouse move.
     makeOpaque();
     if (shouldHideMediaControls(IgnoreVideoHover))
       startHideMediaControlsTimer();
     return;
   }
+
+  if (event->isKeyboardEvent()) {
+    if (!mediaElement().paused()) {
+      makeOpaque();
+      if (shouldHideMediaControls())
+        startHideMediaControlsTimer();
+    }
+
+    int key = toKeyboardEvent(event)->keyCode();
+    switch (key) {
+      case ('\r'):
+      case (' '):
+        m_playButton->defaultEventHandler(event);
+        return;
+      case (37):
+      case (39):
+        timelineElement()->defaultEventHandler(event);
+        onTimeUpdate();

[mlamouri (slow - plz ping), 2017/03/16 12:17:22]

Shouldn't this be called automatically?

[CJ, 2017/03/16 20:08:28]

Didn't seem to work without it. Will double check. 

+        return;
+      case (38):
+      case (40):
+        volumeSliderElement()->defaultEventHandler(event);

[mlamouri (slow - plz ping), 2017/03/16 12:17:22]

For the issue you mention, is onVolueChange called? What happens if you manually
call it?

[CJ, 2017/03/16 20:08:28]

I tried that. Instead of refreshing the blue line after reshowing, it starts the
refresh after it fades away.

+        return;
+    }
+  }
 }
 
 void MediaControls::hideMediaControlsTimerFired(TimerBase*) {
   unsigned behaviorFlags =
       m_hideTimerBehaviorFlags | IgnoreFocus | IgnoreVideoHover;
   m_hideTimerBehaviorFlags = IgnoreNone;
   m_keepShowingUntilTimerFires = false;
 
   if (mediaElement().paused())
     return;
@@ skipping 35 matching lines @@
   m_volumeSlider->setVolume(mediaElement().muted() ? 0
                                                    : mediaElement().volume());
 
   // Update visibility of volume controls.
   // TODO(mlamouri): it should not be part of the volumechange handling because
   // it is using audio availability as input.
   BatchedControlUpdate batch(this);
   m_volumeSlider->setIsWanted(mediaElement().hasAudio() &&
                               !preferHiddenVolumeControls(document()));
   m_muteButton->setIsWanted(mediaElement().hasAudio());
+  startHideMediaControlsTimer();

[mlamouri (slow - plz ping), 2017/03/16 12:17:22]

Why are you hiding this?

[CJ, 2017/03/16 20:08:28]

Not sure why that is there. Removing.

 }
 
 void MediaControls::onFocusIn() {
   if (!mediaElement().shouldShowControls())
     return;
 
   show();
   resetHideMediaControlsTimer();
 }
 
@@ skipping 281 matching lines @@
   visitor->trace(m_overflowList);
   visitor->trace(m_castButton);
   visitor->trace(m_overlayCastButton);
   visitor->trace(m_mediaEventListener);
   visitor->trace(m_windowEventListener);
   visitor->trace(m_orientationLockDelegate);
   HTMLDivElement::trace(visitor);
 }
 
 }  // namespace blink