Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)
Patch Set: Addresses mlamouri's #11 comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 public: 113 public:
114 static MediaControlPlayButtonElement* create(MediaControls&); 114 static MediaControlPlayButtonElement* create(MediaControls&);
115 115
116 bool willRespondToMouseClickEvents() override { return true; } 116 bool willRespondToMouseClickEvents() override { return true; }
117 void updateDisplayType() override; 117 void updateDisplayType() override;
118 118
119 WebLocalizedString::Name getOverflowStringName() override; 119 WebLocalizedString::Name getOverflowStringName() override;
120 120
121 bool hasOverflowButton() override { return true; } 121 bool hasOverflowButton() override { return true; }
122 122
123 void defaultEventHandler(Event*) override;
124
123 private: 125 private:
124 explicit MediaControlPlayButtonElement(MediaControls&); 126 explicit MediaControlPlayButtonElement(MediaControls&);
125
126 void defaultEventHandler(Event*) override;
127 }; 127 };
128 128
129 // ---------------------------- 129 // ----------------------------
130 130
131 class MediaControlOverlayPlayButtonElement final 131 class MediaControlOverlayPlayButtonElement final
132 : public MediaControlInputElement { 132 : public MediaControlInputElement {
133 public: 133 public:
134 static MediaControlOverlayPlayButtonElement* create(MediaControls&); 134 static MediaControlOverlayPlayButtonElement* create(MediaControls&);
135 135
136 void updateDisplayType() override; 136 void updateDisplayType() override;
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 public: 266 public:
267 static MediaControlTimelineElement* create(MediaControls&); 267 static MediaControlTimelineElement* create(MediaControls&);
268 268
269 bool willRespondToMouseClickEvents() override; 269 bool willRespondToMouseClickEvents() override;
270 270
271 // FIXME: An "earliest possible position" will be needed once that concept 271 // FIXME: An "earliest possible position" will be needed once that concept
272 // is supported by HTMLMediaElement, see https://crbug.com/137275 272 // is supported by HTMLMediaElement, see https://crbug.com/137275
273 void setPosition(double); 273 void setPosition(double);
274 void setDuration(double); 274 void setDuration(double);
275 275
276 void defaultEventHandler(Event*) override;
277
276 private: 278 private:
277 explicit MediaControlTimelineElement(MediaControls&); 279 explicit MediaControlTimelineElement(MediaControls&);
278 280
279 void defaultEventHandler(Event*) override;
280 bool keepEventInNode(Event*) override; 281 bool keepEventInNode(Event*) override;
281 }; 282 };
282 283
283 // ---------------------------- 284 // ----------------------------
284 285
285 class MediaControlFullscreenButtonElement final 286 class MediaControlFullscreenButtonElement final
286 : public MediaControlInputElement { 287 : public MediaControlInputElement {
287 public: 288 public:
288 static MediaControlFullscreenButtonElement* create(MediaControls&); 289 static MediaControlFullscreenButtonElement* create(MediaControls&);
289 290
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 // ---------------------------- 348 // ----------------------------
348 349
349 class MediaControlVolumeSliderElement final : public MediaControlInputElement { 350 class MediaControlVolumeSliderElement final : public MediaControlInputElement {
350 public: 351 public:
351 static MediaControlVolumeSliderElement* create(MediaControls&); 352 static MediaControlVolumeSliderElement* create(MediaControls&);
352 353
353 bool willRespondToMouseMoveEvents() override; 354 bool willRespondToMouseMoveEvents() override;
354 bool willRespondToMouseClickEvents() override; 355 bool willRespondToMouseClickEvents() override;
355 void setVolume(double); 356 void setVolume(double);
356 357
358 void defaultEventHandler(Event*) override;
359
357 private: 360 private:
358 explicit MediaControlVolumeSliderElement(MediaControls&); 361 explicit MediaControlVolumeSliderElement(MediaControls&);
359 362
360 void defaultEventHandler(Event*) override;
361 bool keepEventInNode(Event*) override; 363 bool keepEventInNode(Event*) override;
362 }; 364 };
363 365
364 // ---------------------------- 366 // ----------------------------
365 367
366 class MediaControlTimeRemainingDisplayElement final 368 class MediaControlTimeRemainingDisplayElement final
367 : public MediaControlTimeDisplayElement { 369 : public MediaControlTimeDisplayElement {
368 public: 370 public:
369 static MediaControlTimeRemainingDisplayElement* create(MediaControls&); 371 static MediaControlTimeRemainingDisplayElement* create(MediaControls&);
370 372
371 private: 373 private:
372 explicit MediaControlTimeRemainingDisplayElement(MediaControls&); 374 explicit MediaControlTimeRemainingDisplayElement(MediaControls&);
373 }; 375 };
374 376
375 // ---------------------------- 377 // ----------------------------
376 378
377 class MediaControlCurrentTimeDisplayElement final 379 class MediaControlCurrentTimeDisplayElement final
378 : public MediaControlTimeDisplayElement { 380 : public MediaControlTimeDisplayElement {
379 public: 381 public:
380 static MediaControlCurrentTimeDisplayElement* create(MediaControls&); 382 static MediaControlCurrentTimeDisplayElement* create(MediaControls&);
381 383
382 private: 384 private:
383 explicit MediaControlCurrentTimeDisplayElement(MediaControls&); 385 explicit MediaControlCurrentTimeDisplayElement(MediaControls&);
384 }; 386 };
385 387
386 } // namespace blink 388 } // namespace blink
387 389
388 #endif // MediaControlElements_h 390 #endif // MediaControlElements_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698