extensions/browser/guest_view/extension_options/extension_options_guest.cc - Issue 2700613003: Enable find-in-page across GuestViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 2700613003: Enable find-in-page across GuestViews. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « extensions/browser/guest_view/extension_options/extension_options_guest.h ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

index 3441ba961652f616d220ef7989035ef66bd9bc10..38c4da351290b5caac0732548c35693cfb54a941 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

@@ -154,10 +154,6 @@ void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) {

options.ToValue()));

}

-bool ExtensionOptionsGuest::ShouldHandleFindRequestsForEmbedder() const {

- return true;

WebContents* ExtensionOptionsGuest::OpenURLFromTab(

WebContents* source,

const content::OpenURLParams& params) {