Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: components/guest_view/browser/guest_view_base.h

Issue 2700613003: Enable find-in-page across GuestViews. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_base.h
diff --git a/components/guest_view/browser/guest_view_base.h b/components/guest_view/browser/guest_view_base.h
index c900a11b01fde7ce95ad4225444287b944ea5646..5354d87e5a5667bf9f012e44e7fdbaadead8cc92 100644
--- a/components/guest_view/browser/guest_view_base.h
+++ b/components/guest_view/browser/guest_view_base.h
@@ -222,12 +222,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
const content::NativeWebKeyboardEvent& event) override;
bool PreHandleGestureEvent(content::WebContents* source,
const blink::WebGestureEvent& event) override;
- void FindReply(content::WebContents* source,
- int request_id,
- int number_of_matches,
- const gfx::Rect& selection_rect,
- int active_match_ordinal,
- bool final_update) override;
// WebContentsObserver implementation.
void DidFinishNavigation(
@@ -296,11 +290,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// asynchronous setup.
virtual void SignalWhenReady(const base::Closure& callback);
- // Returns true if this guest should handle find requests for its
- // embedder. This should generally be true for guests that make up the
- // entirety of the embedder's content.
- virtual bool ShouldHandleFindRequestsForEmbedder() const;
-
// This method is called immediately before suspended resource loads have been
// resumed on attachment to an embedder.
//
@@ -345,10 +334,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
void DidAttach(int guest_proxy_routing_id) final;
void DidDetach() final;
content::WebContents* GetOwnerWebContents() const final;
- bool HandleFindForEmbedder(int request_id,
- const base::string16& search_text,
- const blink::WebFindOptions& options) final;
- bool HandleStopFindingForEmbedder(content::StopFindAction action) final;
void GuestSizeChanged(const gfx::Size& new_size) final;
void SetGuestHost(content::GuestHost* guest_host) final;
void WillAttach(content::WebContents* embedder_web_contents,

Powered by Google App Engine
This is Rietveld 408576698