Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: icu.gyp

Issue 270058: ARM: Work around ICE with gcc-4.3 when building ICU (Closed) Base URL: http://src.chromium.org/svn/trunk/deps/third_party/icu42/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'defines': [ 7 'defines': [
8 'U_STATIC_IMPLEMENTATION', 8 'U_STATIC_IMPLEMENTATION',
9 ], 9 ],
10 # TODO(mark): Looks like this is causing the "public" include directories 10 # TODO(mark): Looks like this is causing the "public" include directories
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 # Use prepend (+) because the WebKit build needs to pick up these 200 # Use prepend (+) because the WebKit build needs to pick up these
201 # ICU headers instead of the ones in ../WebKit/JavaScriptCore/wtf, 201 # ICU headers instead of the ones in ../WebKit/JavaScriptCore/wtf,
202 # also in WebKit's include path. 202 # also in WebKit's include path.
203 # TODO(mark): The double + is a bug. It should be a single +. It 203 # TODO(mark): The double + is a bug. It should be a single +. It
204 # seems that a + is being chopped off when the "target" section is 204 # seems that a + is being chopped off when the "target" section is
205 # merged into "target_defaults". 205 # merged into "target_defaults".
206 'include_dirs++': [ 206 'include_dirs++': [
207 'public/i18n', 207 'public/i18n',
208 ], 208 ],
209 }, 209 },
210 'conditions': [
211 ['target_arch=="arm"', {
Antoine Labour 2009/11/13 19:20:17 could you add armv7!=1 ? I never had an issue on a
212 # When targetting ARMv5 with gcc-4.3 at -O2 (as well as O3 and O1) an
213 # internal compiler error (ICE) is triggered in
214 # source/i18n/rematch.cpp. The work around is to build this target
215 # without specifying an optimisation level.
216 'cflags!': [ '-O1', '-O2', '-O3' ],
217 }],
218 ],
210 }, 219 },
211 { 220 {
212 'target_name': 'icuuc', 221 'target_name': 'icuuc',
213 'type': '<(library)', 222 'type': '<(library)',
214 'msvs_guid': '9E2EFAAB-02B7-4A82-B664-1E98DF6D1953', 223 'msvs_guid': '9E2EFAAB-02B7-4A82-B664-1E98DF6D1953',
215 'sources': [ 224 'sources': [
216 'source/common/bmpset.cpp', 225 'source/common/bmpset.cpp',
217 'source/common/brkeng.cpp', 226 'source/common/brkeng.cpp',
218 'source/common/brkiter.cpp', 227 'source/common/brkiter.cpp',
219 'source/common/bytestream.cpp', 228 'source/common/bytestream.cpp',
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 'cflags': [ 400 'cflags': [
392 '-Wno-unused-function', 401 '-Wno-unused-function',
393 # TODO(port): fix ICU to not depend on this flag. 402 # TODO(port): fix ICU to not depend on this flag.
394 '-fno-strict-aliasing', 403 '-fno-strict-aliasing',
395 ], 404 ],
396 },], 405 },],
397 ], 406 ],
398 }, 407 },
399 ], 408 ],
400 } 409 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698