Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.h

Issue 2700553002: Introduce WebRequestResourceType. (Closed)
Patch Set: Fix fix win build. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api_helpers.h
diff --git a/extensions/browser/api/web_request/web_request_api_helpers.h b/extensions/browser/api/web_request/web_request_api_helpers.h
index fae87e724ae8931d27dbd89c23cae47e6b006112..d1e9ca764668216b027995f8ca4c56fdb67dc561 100644
--- a/extensions/browser/api/web_request/web_request_api_helpers.h
+++ b/extensions/browser/api/web_request/web_request_api_helpers.h
@@ -17,6 +17,7 @@
#include "base/memory/ref_counted.h"
#include "base/time/time.h"
#include "content/public/common/resource_type.h"
+#include "extensions/browser/api/web_request/web_request_resource_type.h"
#include "extensions/browser/warning_set.h"
#include "net/base/auth.h"
#include "net/http/http_request_headers.h"
@@ -329,19 +330,19 @@ std::unique_ptr<base::DictionaryValue> CreateHeaderDictionary(
const std::string& name,
const std::string& value);
-// Returns whether |type| is a ResourceType that is handled by the web request
-// API.
+// Returns whether |type| is a content::ResourceType that is handled by the web
+// request API.
bool IsRelevantResourceType(content::ResourceType type);
// Returns a string representation of |type| or |other| if |type| is not handled
// by the web request API.
-const char* ResourceTypeToString(content::ResourceType type);
+const char* ResourceTypeToString(extensions::WebRequestResourceType type);
-// Stores a |content::ResourceType| representation in |types| if |type_str| is
-// a resource type handled by the web request API. Returns true in case of
-// success.
+// Stores an |extension::WebRequestResourceType| representation in |types| if
Devlin 2017/02/16 15:13:05 nit: s/extension::/extensions::
pkalinnikov 2017/02/16 15:52:45 Done.
+// |type_str| is a resource type handled by the web request API. Returns true in
+// case of success.
bool ParseResourceType(const std::string& type_str,
- std::vector<content::ResourceType>* types);
+ std::vector<extensions::WebRequestResourceType>* types);
} // namespace extension_web_request_api_helpers

Powered by Google App Engine
This is Rietveld 408576698