Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2614)

Unified Diff: extensions/browser/api/web_request/web_request_api.h

Issue 2700553002: Introduce WebRequestResourceType. (Closed)
Patch Set: Make compiler happy; make type<->string mapping self-checking. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api.h
diff --git a/extensions/browser/api/web_request/web_request_api.h b/extensions/browser/api/web_request/web_request_api.h
index 7ccb8fd8da21224a3ecf07b451aa6610a22cfdd0..32fdffd9e8dd502eff2fc2d5f1956435170e0dcd 100644
--- a/extensions/browser/api/web_request/web_request_api.h
+++ b/extensions/browser/api/web_request/web_request_api.h
@@ -20,7 +20,6 @@
#include "base/memory/weak_ptr.h"
#include "base/strings/string_util.h"
#include "base/time/time.h"
-#include "content/public/common/resource_type.h"
#include "extensions/browser/api/declarative/rules_registry.h"
#include "extensions/browser/api/declarative_webrequest/request_stage.h"
#include "extensions/browser/api/web_request/web_request_api_helpers.h"
@@ -54,6 +53,9 @@ class URLRequest;
}
namespace extensions {
+
+enum class WebRequestResourceType : uint8_t;
+
class ExtensionNavigationUIData;
class InfoMap;
class WebRequestEventDetails;
@@ -123,7 +125,7 @@ class ExtensionWebRequestEventRouter
bool InitFromValue(const base::DictionaryValue& value, std::string* error);
extensions::URLPatternSet urls;
- std::vector<content::ResourceType> types;
+ std::vector<WebRequestResourceType> types;
int tab_id;
int window_id;
};
@@ -439,7 +441,7 @@ class ExtensionWebRequestEventRouter
const GURL& url,
int render_process_host_id,
int routing_id,
- content::ResourceType resource_type,
+ WebRequestResourceType resource_type,
bool is_async_request,
bool is_request_from_extension,
int* extra_info_spec,

Powered by Google App Engine
This is Rietveld 408576698