Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h

Issue 2700553002: Introduce WebRequestResourceType. (Closed)
Patch Set: Make compiler happy; make type<->string mapping self-checking. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h
diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h
index 8c6dbe5b816f2c15b123851a849344bad0aa9327..78206ad048776bc9680c3b85aac5a77184cd3651 100644
--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h
+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h
@@ -5,13 +5,13 @@
#ifndef EXTENSIONS_BROWSER_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_CONDITION_ATTRIBUTE_H_
#define EXTENSIONS_BROWSER_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_CONDITION_ATTRIBUTE_H_
+#include <stdint.h>
#include <memory>
#include <string>
#include <vector>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "content/public/common/resource_type.h"
#include "extensions/browser/api/declarative_webrequest/request_stage.h"
#include "extensions/common/api/events.h"
@@ -21,6 +21,8 @@ class Value;
namespace extensions {
+enum class WebRequestResourceType : uint8_t;
+
class HeaderMatcher;
struct WebRequestData;
@@ -100,10 +102,11 @@ class WebRequestConditionAttributeResourceType
private:
explicit WebRequestConditionAttributeResourceType(
- const std::vector<content::ResourceType>& types);
+ const std::vector<WebRequestResourceType>& types);
~WebRequestConditionAttributeResourceType() override;
- const std::vector<content::ResourceType> types_;
+ // TODO(pkalinnikov): Make this a bitmask.
+ const std::vector<WebRequestResourceType> types_;
DISALLOW_COPY_AND_ASSIGN(WebRequestConditionAttributeResourceType);
};

Powered by Google App Engine
This is Rietveld 408576698