extensions/browser/api/web_request/web_request_resource_type.cc - Issue 2700553002: Introduce WebRequestResourceType.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/api/web_request/web_request_resource_type.cc

Issue 2700553002: Introduce WebRequestResourceType. (Closed)

Patch Set: Address comments from Devlin. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "extensions/browser/api/web_request/web_request_resource_type.h"

	6

	7 #include "base/logging.h"

	8 #include "content/public/browser/resource_request_info.h"

	9 #include "net/url_request/url_request.h"

	10

	11 namespace extensions {

	12

	13 WebRequestResourceType ToWebRequestResourceType(

	14 const net::URLRequest* request) {

	15 DCHECK(request);

	16 if (request->url().SchemeIsWSOrWSS())

	17 return WebRequestResourceType::WEB_SOCKET;

	18 const auto* info = content::ResourceRequestInfo::ForRequest(request);

	19 return info ? ToWebRequestResourceType(info->GetResourceType())

	20 : WebRequestResourceType::OTHER;
	Devlin 2017/02/16 16:08:26 and then return INVALID if info is null rather tha and then return INVALID if info is null rather than OTHER pkalinnikov 2017/02/16 19:27:33 Done. Show quoted text On 2017/02/16 16:08:26, Devlin wrote: > and then return INVALID if info is null rather than OTHER Done.
	21 }

	22

	23 } // namespace extensions

OLD	NEW