cc/ipc/copy_output_request.mojom - Issue 2700533002: CopyOutputRequest must have a working result_callback_ when received over mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/copy_output_request.mojom

Issue 2700533002: CopyOutputRequest must have a working result_callback_ when received over mojo (Closed)

Patch Set: Addressed Dana's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module cc.mojom;	5 module cc.mojom;

6	6

	7 import "cc/ipc/copy_output_result.mojom";

7 import "cc/ipc/texture_mailbox.mojom";	8 import "cc/ipc/texture_mailbox.mojom";

8 import "mojo/common/unguessable_token.mojom";	9 import "mojo/common/unguessable_token.mojom";

9 import "ui/gfx/geometry/mojo/geometry.mojom";	10 import "ui/gfx/geometry/mojo/geometry.mojom";

10	11

11 // See cc/output/copy_output_request.h.	12 // See cc/output/copy_output_request.h.

12 // Note: result_callback_ is not included in this struct.

13 struct CopyOutputRequest {	13 struct CopyOutputRequest {

14 mojo.common.mojom.UnguessableToken? source;	14 mojo.common.mojom.UnguessableToken? source;

15 bool force_bitmap_result;	15 bool force_bitmap_result;

16 gfx.mojom.Rect? area;	16 gfx.mojom.Rect? area;

17 cc.mojom.TextureMailbox? texture_mailbox;	17 TextureMailbox? texture_mailbox;

	18 CopyOutputResultSender? result_sender;
	danakj 2017/02/15 19:48:19 How come this is nullable? (Sorry for being foreve How come this is nullable? (Sorry for being forever confused about this)
18 };	19 };

	20

	21 // When the display compositor is ready to respond to the CopyOutputRequest,

	22 // it uses this interface to send back the result.

	23 interface CopyOutputResultSender {

	24 SendResult(CopyOutputResult result);

	25 };

OLD	NEW

« no previous file with comments | « no previous file | cc/ipc/copy_output_request_struct_traits.h » ('j') | cc/ipc/copy_output_request_struct_traits.cc » ('J')