Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc

Issue 2700523004: Remove docked windows entirely in M59. (Closed)
Patch Set: Yet another Rebase ... Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
index b94bfc40986d77ad5c7e07eb980b78c554333292..bea17cd78329f892866378e0a31f1fea1966bad9 100644
--- a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
+++ b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
@@ -1571,27 +1571,6 @@ TEST_F(MaximizeModeWindowManagerTest, AlwaysOnTopWindows) {
EXPECT_TRUE(wm::GetWindowState(w2.get())->can_be_dragged());
}
-// Tests that docked windows are not maximized, and not tracked.
-TEST_F(MaximizeModeWindowManagerTest, DontMaximizeDockedWindows) {
- // Enable window docking for this test.
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- ash::switches::kAshEnableDockedWindows);
-
- gfx::Rect rect(10, 10, 200, 50);
- std::unique_ptr<aura::Window> window(
- CreateWindow(ui::wm::WINDOW_TYPE_NORMAL, rect));
-
- wm::WMEvent dock_event(wm::WM_EVENT_DOCK);
- wm::GetWindowState(window.get())->OnWMEvent(&dock_event);
- EXPECT_TRUE(wm::GetWindowState(window.get())->IsDocked());
- EXPECT_FALSE(wm::GetWindowState(window.get())->IsMaximized());
-
- MaximizeModeWindowManager* manager = CreateMaximizeModeWindowManager();
- EXPECT_TRUE(wm::GetWindowState(window.get())->IsDocked());
- EXPECT_FALSE(wm::GetWindowState(window.get())->IsMaximized());
- EXPECT_EQ(0, manager->GetNumberOfManagedWindows());
-}
-
// Tests that windows that can control maximized bounds are not maximized
// and not tracked.
TEST_F(MaximizeModeWindowManagerTest, DontMaximizeClientManagedWindows) {

Powered by Google App Engine
This is Rietveld 408576698