Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: ash/common/accelerators/accelerator_controller.cc

Issue 2700523004: Remove docked windows entirely in M59. (Closed)
Patch Set: sky's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/accelerators/accelerator_controller.cc
diff --git a/ash/common/accelerators/accelerator_controller.cc b/ash/common/accelerators/accelerator_controller.cc
index e4af731eaf1daf597b447b00805f4e9526e78552..0226770f71e1cacddc737c10fc7d544455e1c6a9 100644
--- a/ash/common/accelerators/accelerator_controller.cc
+++ b/ash/common/accelerators/accelerator_controller.cc
@@ -402,7 +402,7 @@ void HandleToggleOverview() {
WmShell::Get()->window_selector_controller()->ToggleOverview();
}
-bool CanHandleWindowSnapOrDock() {
+bool CanHandleWindowSnap() {
WmWindow* active_window = WmShell::Get()->GetActiveWindow();
if (!active_window)
return false;
@@ -413,15 +413,15 @@ bool CanHandleWindowSnapOrDock() {
!window_state->IsFullscreen());
}
-void HandleWindowSnapOrDock(AcceleratorAction action) {
- if (action == WINDOW_CYCLE_SNAP_DOCK_LEFT)
+void HandleWindowSnap(AcceleratorAction action) {
+ if (action == WINDOW_CYCLE_SNAP_LEFT)
base::RecordAction(UserMetricsAction("Accel_Window_Snap_Left"));
else
base::RecordAction(UserMetricsAction("Accel_Window_Snap_Right"));
- const wm::WMEvent event(action == WINDOW_CYCLE_SNAP_DOCK_LEFT
- ? wm::WM_EVENT_CYCLE_SNAP_DOCK_LEFT
- : wm::WM_EVENT_CYCLE_SNAP_DOCK_RIGHT);
+ const wm::WMEvent event(action == WINDOW_CYCLE_SNAP_LEFT
+ ? wm::WM_EVENT_CYCLE_SNAP_LEFT
+ : wm::WM_EVENT_CYCLE_SNAP_RIGHT);
WmWindow* active_window = WmShell::Get()->GetActiveWindow();
DCHECK(active_window);
active_window->GetWindowState()->OnWMEvent(&event);
@@ -433,9 +433,7 @@ void HandleWindowMinimize() {
}
bool CanHandlePositionCenter() {
- // Docked windows do not support centering.
- WmWindow* active_window = WmShell::Get()->GetActiveWindow();
- return (active_window && !active_window->GetWindowState()->IsDocked());
+ return WmShell::Get()->GetActiveWindow() != nullptr;
}
void HandlePositionCenter() {
@@ -916,9 +914,9 @@ bool AcceleratorController::CanPerformAction(
return CanHandleToggleAppList(accelerator, previous_accelerator);
case TOGGLE_CAPS_LOCK:
return CanHandleToggleCapsLock(accelerator, previous_accelerator);
- case WINDOW_CYCLE_SNAP_DOCK_LEFT:
- case WINDOW_CYCLE_SNAP_DOCK_RIGHT:
- return CanHandleWindowSnapOrDock();
+ case WINDOW_CYCLE_SNAP_LEFT:
+ case WINDOW_CYCLE_SNAP_RIGHT:
+ return CanHandleWindowSnap();
case WINDOW_POSITION_CENTER:
return CanHandlePositionCenter();
@@ -1188,9 +1186,9 @@ void AcceleratorController::PerformAction(AcceleratorAction action,
case VOLUME_UP:
HandleVolumeUp(volume_controller_.get(), accelerator);
break;
- case WINDOW_CYCLE_SNAP_DOCK_LEFT:
- case WINDOW_CYCLE_SNAP_DOCK_RIGHT:
- HandleWindowSnapOrDock(action);
+ case WINDOW_CYCLE_SNAP_LEFT:
+ case WINDOW_CYCLE_SNAP_RIGHT:
+ HandleWindowSnap(action);
break;
case WINDOW_MINIMIZE:
HandleWindowMinimize();

Powered by Google App Engine
This is Rietveld 408576698