chrome/common/extensions/api/windows.json - Issue 2700523004: Remove docked windows entirely in M59.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/windows.json

Issue 2700523004: Remove docked windows entirely in M59. (Closed)

Patch Set: Rebase + Nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/window_sizer/window_sizer.cc ('k') | components/sessions/core/session_service_commands.cc » ('j') | components/sessions/core/session_service_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/windows.json

diff --git a/chrome/common/extensions/api/windows.json b/chrome/common/extensions/api/windows.json

index ed3f6013c7e49821b6a936c8f22ddffa46ec508f..99e97d87e61efd0f4777d7138029488598284044 100644

--- a/chrome/common/extensions/api/windows.json

+++ b/chrome/common/extensions/api/windows.json

@@ -20,7 +20,7 @@

"id": "WindowState",

"type": "string",

"description": "The state of this browser window. Under some circumstances a Window may not be assigned state property, for example when querying closed windows from the $(ref:sessions) API.",

- "enum": ["normal", "minimized", "maximized", "fullscreen", "docked"]

sky 2017/03/16 04:24:23 What happens if docked is still used?

varkha 2017/03/16 14:13:54 I think because the state is never set to DOCKED b

afakhry 2017/03/16 17:50:23 I also think like what varkha said below, but addi

afakhry 2017/03/16 17:50:23 Acknowledged.

+ "enum": ["normal", "minimized", "maximized", "fullscreen"]

{

"id": "Window",